Upgrade to PyYAML 6.0.1 - #1508
Merged
Merged
Conversation
jdeanwallace
marked this pull request as ready for review
July 18, 2023 13:11
Contributor
Author
Automated comment from CodeApprove ➜⏳ @mtlynch please review this Pull Request |
mtlynch
approved these changes
Jul 18, 2023
mtlynch
left a comment
mtlynch
left a comment
Contributor
There was a problem hiding this comment.
Automated comment from CodeApprove ➜
✔️ Approved
LGTM, thanks!
👀 @jdeanwallace it's your turn please take a look
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1507
The release of Cython
3broke PyYAML5.4. This PR upgrades to PyYAML6.0.1which pinsCython < 3.0.0.Notes
The conflict is caused by: The user requested PyYAML==6.0.1 molecule 3.2.3 depends on PyYAML<6 and >=5.1pyyamlto version5.3.1. However, I only did this for the molecule dependencies.